This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
When flipping views, if the doc is already open on the other view, show it without closing the original pane #12248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ow it without closing the original pane
swmitra
approved these changes
Feb 10, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In d72753b there was an hotfix that prevented flipping files that were already open in the other pane (due to issues with merging views that have inline widgets open).
This PR changes it so that flipping an view that is already on the other pane just shows the other file in the other pane, being somewhat inline with the general
split-view-same-docconcept. PR has an test included.Tagging @swmitra